#35115: Empty footer element in main section of admin layout
--------------------------------------+------------------------------------
Reporter: Marijke Luttekes | Owner: nobody
Type: Cleanup/optimization | Status: new
Component: contrib.admin | Version: 5.0
Severity: Normal | Resolution:
Keywords: HTML | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
--------------------------------------+------------------------------------
Changes (by Mariusz Felisiak):
* stage: Unreviewed => Accepted
Comment:
Replying to [comment:3 Tom Carrick]:
> Yeah I think this is intended to be overridden. I agree with removing
the CSS, and also with moving it out of the main element and to use a
semantic footer element by default.
Sounds like a plan.
{{{#!diff
diff --git a/django/contrib/admin/templates/admin/base.html
b/django/contrib/admin/templates/admin/base.html
index 1ca50e508d..46d75c6090 100644
--- a/django/contrib/admin/templates/admin/base.html
+++ b/django/contrib/admin/templates/admin/base.html
@@ -108,8 +108,8 @@
<br class="clear">
</div>
<!-- END Content -->
- {% block footer %}<div id="footer"></div>{% endblock %}
</main>
+ {% block footer %}<footer></footer>{% endblock %}
</div>
</div>
<!-- END Container -->
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/35115#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018d109169e1-2bae2ebd-8bde-45c2-92b0-9af168fec2f9-000000%40eu-central-1.amazonses.com.
