Author: russellm
Date: 2008-07-12 01:16:42 -0500 (Sat, 12 Jul 2008)
New Revision: 7900

Modified:
   django/trunk/docs/testing.txt
   django/trunk/tests/modeltests/test_client/models.py
   django/trunk/tests/modeltests/test_client/urls.py
   django/trunk/tests/modeltests/test_client/views.py
Log:
Fixed #7583 -- Corrected the testing docs that referred to the defunct headers 
attribute of the response. Added a test case to validate (and document) the new 
behavior. Thanks to Malcolm for the report.

Modified: django/trunk/docs/testing.txt
===================================================================
--- django/trunk/docs/testing.txt       2008-07-11 18:21:55 UTC (rev 7899)
+++ django/trunk/docs/testing.txt       2008-07-12 06:16:42 UTC (rev 7900)
@@ -600,8 +600,6 @@
                      ``context`` will be a list of ``Context``
                      objects, in the order in which they were rendered.
 
-    ``headers``      The HTTP headers of the response. This is a dictionary.
-
     ``request``      The request data that stimulated the response.
 
     ``status_code``  The HTTP status of the response, as an integer. See
@@ -619,6 +617,10 @@
                      which they were rendered.
     ===============  ==========================================================
 
+You can also use dictionary syntax on the response object to query the value
+of any settings in the HTTP headers. For example, you could determine the
+content type of a response using ``response['Content-Type']``.
+
 .. _RFC2616: http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html
 .. _template inheritance: ../templates/#template-inheritance
 

Modified: django/trunk/tests/modeltests/test_client/models.py
===================================================================
--- django/trunk/tests/modeltests/test_client/models.py 2008-07-11 18:21:55 UTC 
(rev 7899)
+++ django/trunk/tests/modeltests/test_client/models.py 2008-07-12 06:16:42 UTC 
(rev 7900)
@@ -70,7 +70,13 @@
         self.assertEqual(response.context['data'], '37')
         self.assertEqual(response.template.name, 'POST Template')
         self.failUnless('Data received' in response.content)
-
+    
+    def test_response_headers(self):
+        "Check the value of HTTP headers returned in a response"
+        response = self.client.get("/test_client/header_view/")
+        
+        self.assertEquals(response['X-DJANGO-TEST'], 'Slartibartfast')
+        
     def test_raw_post(self):
         "POST raw data (with a content type) to a view"
         test_doc = """<?xml version="1.0" 
encoding="utf-8"?><library><book><title>Blink</title><author>Malcolm 
Gladwell</author></book></library>"""

Modified: django/trunk/tests/modeltests/test_client/urls.py
===================================================================
--- django/trunk/tests/modeltests/test_client/urls.py   2008-07-11 18:21:55 UTC 
(rev 7899)
+++ django/trunk/tests/modeltests/test_client/urls.py   2008-07-12 06:16:42 UTC 
(rev 7900)
@@ -5,6 +5,7 @@
 urlpatterns = patterns('',
     (r'^get_view/$', views.get_view),
     (r'^post_view/$', views.post_view),
+    (r'^header_view/$', views.view_with_header),
     (r'^raw_post_view/$', views.raw_post_view),
     (r'^redirect_view/$', views.redirect_view),
     (r'^permanent_redirect_view/$', redirect_to, { 'url': 
'/test_client/get_view/' }),

Modified: django/trunk/tests/modeltests/test_client/views.py
===================================================================
--- django/trunk/tests/modeltests/test_client/views.py  2008-07-11 18:21:55 UTC 
(rev 7899)
+++ django/trunk/tests/modeltests/test_client/views.py  2008-07-12 06:16:42 UTC 
(rev 7900)
@@ -32,6 +32,12 @@
 
     return HttpResponse(t.render(c))
 
+def view_with_header(request):
+    "A view that has a custom header"
+    response = HttpResponse()
+    response['X-DJANGO-TEST'] = 'Slartibartfast'
+    return response
+        
 def raw_post_view(request):
     """A view which expects raw XML to be posted and returns content extracted
     from the XML"""


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to