#35197: floatformat combined with intcomma filters misformatting in Django 
4.2.10
-------------------------------------+-------------------------------------
     Reporter:  nathangeffen         |                    Owner:  nobody
         Type:  Bug                  |                   Status:  new
    Component:  Template system      |                  Version:  4.2
     Severity:  Normal               |               Resolution:
     Keywords:  intcomma,            |             Triage Stage:
  floatformat                        |  Unreviewed
    Has patch:  0                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  1
-------------------------------------+-------------------------------------
Description changed by nathangeffen:

Old description:

> A security bug was removed from the intcomma template filter in Django
> 4.2.10. But it appears a bug was introduced that misformats numbers when
> the intcomma filter is combined with floatformat.
> The problem is a leading comma is added to some numbers (I suspect it is
> numbers with exactly 3 digits).
>
> Example code that worked in 4.2.7 but now misformatting in 4.2.10:
> {{total_amount|floatformat:"2"|intcomma}}
>
> I have not filed a bug on this system before and hope to be able to
> attach screenshots.

New description:

 A security bug was removed from the intcomma template filter in Django
 4.2.10. But it appears a bug was introduced that misformats numbers when
 the intcomma filter is combined with floatformat.
 The problem is a leading comma is added to some numbers (I suspect it is
 numbers with exactly 3 digits).

 Example code that worked in 4.2.7 but now misformatting in 4.2.10:
 {{total_amount|floatformat:"2"|intcomma}}

 In the attached screenshots the bug is apparent. They are the same screen
 displayed using 4.2.7 and 4.2.10. Note the leading comma before 3 digit
 numbers in the one screenshot (that's 4.2.10).

--
-- 
Ticket URL: <https://code.djangoproject.com/ticket/35197#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dac6e3752-705757eb-f61d-4047-ae82-d0a256b595cd-000000%40eu-central-1.amazonses.com.

Reply via email to