#35234: ExclusionConstraint.expressions should be checked for foreign 
relationship
references
-------------------------------------+-------------------------------------
     Reporter:  Simon Charette       |                    Owner:  Simon
         Type:                       |  Charette
  Cleanup/optimization               |                   Status:  assigned
    Component:  contrib.postgres     |                  Version:  5.0
     Severity:  Normal               |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by David Sanders):

 * cc: David Sanders (added)

Comment:

 Just on the `._check` naming, imho this could confuse people by leading
 them to believe there's a relationship between `.check()` and `._check`?
 🤷‍♂️

 As for suggestions, the only thing I could think of was to be more
 specific, perhaps `._check_expression` ?  Would be inline with
 `._db_default_expression`. But then we have the dilemma of diverging from
 the kwarg `check` passed to CheckConstraint.
-- 
Ticket URL: <https://code.djangoproject.com/ticket/35234#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018dcf58a214-c97fa6bf-8815-4944-9cb0-a63280381cd5-000000%40eu-central-1.amazonses.com.

Reply via email to