#35270: Optimize Model._meta._property_names
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Adam
Type: | Johnson
Cleanup/optimization | Status: assigned
Component: Database layer | Version: dev
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Natalia Bidart):
* stage: Unreviewed => Accepted
Comment:
Replying to [comment:4 Adam Johnson]:
[...]
> The result was that the calls took 2ms, keeping most of the savings.
That said, the project I’m using doesn’t have deep model inheritance or
many mixins, so we wouldn’t expect the caching to do so much.
>
> If you’d both prefer this version, sure, we can go for it. Best to keep
things maintainable for all, and we can always add `@weak_key_cache` or
similar in the future.
I'm very much in favor of a simpler optimization. I agree with Keryn that
`@weak_key_cache` is the kind of deep magic is not fully understood
immediately.
Accepting following this simplification proposal.
--
Ticket URL: <https://code.djangoproject.com/ticket/35270#comment:5>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/0107018e1a15ee65-bb13ced3-1ff2-4fdd-ae78-78930c0406bb-000000%40eu-central-1.amazonses.com.
