#32319: Add support to HashedFilesMixin for ES modules
-------------------------------------+-------------------------------------
     Reporter:  gilmrjc              |                    Owner:  blighj
         Type:  New feature          |                   Status:  closed
    Component:  contrib.staticfiles  |                  Version:  dev
     Severity:  Normal               |               Resolution:  fixed
     Keywords:                       |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Comment (by Michael):

 Thank for fixing the issue, I just came across a mistake in the regex I
 posted above:
 {{{
 (
 
r"""(?P<matched>(?P<import_as>import\s*\*as\s\S)+\s+from\s*["'](?P<url>[./].*?)["']\s*;)""",
                 """%(import_as)s from "%(url)s";""",
             ),
 }}}
 Should be (the plus should be for one of more chars of the import as name,
 not groups, so the plus moved one char to the left:
 {{{
 (
 
r"""(?P<matched>(?P<import_as>import\s*\*as\s\S+)\s+from\s*["'](?P<url>[./].*?)["']\s*;)""",
                 """%(import_as)s from "%(url)s";""",
             ),
 }}}
-- 
Ticket URL: <https://code.djangoproject.com/ticket/32319#comment:25>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070190456fe039-83c2c47c-43d0-4f54-ba98-bdfa0a766d56-000000%40eu-central-1.amazonses.com.

Reply via email to