#7805: ImageField doesn't need its own get_internal_type() ------------------------------+--------------------------------------------- Reporter: Gulopine | Owner: nobody Status: new | Milestone: Component: Database wrapper | Version: SVN Keywords: | Stage: Unreviewed Has_patch: 1 | ------------------------------+--------------------------------------------- After [7133] went in, it was no longer assumed that most fields in Django would have `get_internal_type()` return the name of the class; instead, it's expected to return something that really defines how it should be stored internally. `ImageField` is a specialized `FileField`, but that specialization has no bearing on how it's stored int he database or anywhere else, so having its `get_internal_type()` return a separate value is essentially useless. Doing so also requires all backends to include a separate entry for `ImageField`, which essentially has to be a duplicate of `FileField` in order to meet expectations, especially if anyone should ever switch from one field type to another.
It makes more sense to simply do away with the internal type of `ImageField` altogether and have it simply inherit the `FileField` type. There doesn't seem to be any value in making the distinction. -- Ticket URL: <http://code.djangoproject.com/ticket/7805> Django Code <http://code.djangoproject.com/> The web framework for perfectionists with deadlines --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-updates?hl=en -~----------~----~----~----~------~----~------~--~---
