#35759: Don't require max_length on CharField on SQLite backend
-------------------------------------+-------------------------------------
Reporter: Curtis Maloney | Owner: Jae Hyuck
| Sa
Type: New feature | Status: assigned
Component: Database layer | Version: 5.0
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Jae Hyuck Sa ):
Replying to [comment:6 Simon Charette]:
> Patch is looking great.
>
> For the record #34887 initially rejected this feature but I think it
warrants being revisited. The argument provided by Mariusz at the time was
>
> > We accepted #14094, because CharField and TextField use different
datatypes on PostgreSQL.
>
> but in the end both `varchar` and `text`
[https://www.depesz.com/2010/03/02/charx-vs-varcharx-vs-varchar-vs-text/
are aliases for the internal Postgres] `varlena` type so I don't think the
argument stands. There are reason why we'd want to allow
`CharField(max_length=None)` on
[https://code.djangoproject.com/ticket/14094#comment:5 all backends that
allow it] which #14094 does a good job at covering.
Thank you for the detailed explanation! :)
>
> Moreover the addition of this feature could allow us to eventually
automatically add a check constraint for `max_length` on SQLite by
allowing users to disable it entirely by setting the value to `None`.
--
Ticket URL: <https://code.djangoproject.com/ticket/35759#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/01070191ec4853dd-42e634b2-7134-43d4-917d-5e568c38d654-000000%40eu-central-1.amazonses.com.
