#35920: Migrate command runs system checks regardless of the value of
requires_system_checks
-------------------------------------+-------------------------------------
Reporter: Jacob Walls | Owner: Jacob
| Walls
Type: Bug | Status: assigned
Component: Core (Management | Version: 5.1
commands) |
Severity: Normal | Resolution:
Keywords: skip-checks | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Jacob Walls):
* has_patch: 0 => 1
Comment:
[https://github.com/django/django/pull/18839 PR]
----
Update on this side point:
> I suppose there's another question here about whether Tags.models checks
should run as part of the migrate command, or whether the change I made at
the project level should be pulled into core, given that this is a
reasonably realistic scenario for development? I can take that to the
forum later.
On second thought, that's a bad idea. Initially I missed the
[https://docs.djangoproject.com/en/5.1/topics/checks/#writing-your-own-
checks caveat] that you need to guard your system check under `if
kwargs["database"]:` if you're going to make queries. Guarding like that
was sufficient to prevent the failures.
--
Ticket URL: <https://code.djangoproject.com/ticket/35920#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/010701935aab4452-4718b7b8-3e07-4170-880a-adf18e9a025e-000000%40eu-central-1.amazonses.com.
