#36002: Errors in RemoteUserMiddleware/PersistentRemoteUserMiddleware docstrings
and code comments
-------------------------------------+-------------------------------------
Reporter: Anders Einar Hilden | Owner: Anders
Type: | Einar Hilden
Cleanup/optimization | Status: closed
Component: contrib.auth | Version: dev
Severity: Normal | Resolution: invalid
Keywords: | Triage Stage:
RemoteUserMiddleware, | Unreviewed
PersistentRemoteUserMiddleware |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):
* resolution: => invalid
* status: assigned => closed
Comment:
[https://docs.djangoproject.com/en/5.1/ref/request-
response/#django.http.HttpRequest.META HttpRequest.META] is a dictionary
of headers. On WSGI, these are initiated from
[https://github.com/django/django/blob/6f38697f90a14f1450a71c1e40aea0f5df7dca86/django/core/handlers/wsgi.py#L68
environment variables].
I think both the docs and the doc strings are correct. The docs refer to
how the header is likely to be set (from the environment variable) and the
docstring is on what it actually is looking at (the header).
--
Ticket URL: <https://code.djangoproject.com/ticket/36002#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/01070193ba8eb10a-86ca9539-345e-4018-a93d-53f8c3ca9637-000000%40eu-central-1.amazonses.com.
