#36002: RemoteUserMiddleware/PersistentRemoteUserMiddleware docstrings and code
comments refer to "headers" rather than request.META keys
-------------------------------------+-------------------------------------
Reporter: Anders Einar Hilden | Owner: Anders
Type: | Einar Hilden
Cleanup/optimization | Status: new
Component: contrib.auth | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
RemoteUserMiddleware, |
PersistentRemoteUserMiddleware |
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 1 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):
* needs_better_patch: 0 => 1
* resolution: invalid =>
* stage: Unreviewed => Accepted
* status: closed => new
* summary:
Errors in RemoteUserMiddleware/PersistentRemoteUserMiddleware
docstrings and code comments
=>
RemoteUserMiddleware/PersistentRemoteUserMiddleware docstrings and
code comments refer to "headers" rather than request.META keys
Comment:
Accepting after further investigation
Also looks like some clarification in the
[https://docs.djangoproject.com/en/5.1/ref/request-
response/#django.http.HttpRequest.META HttpRequest.META] docs would be
beneficial to clarify that these are not exclusively headers and contain
things like [https://datatracker.ietf.org/doc/html/rfc3875#section-4.1
request Meta variables] but that discussion should perhaps happen on the
forum to iron things out
--
Ticket URL: <https://code.djangoproject.com/ticket/36002#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/01070193bb25b53b-95f16efa-27cb-40a7-96cc-139fd20e33b9-000000%40eu-central-1.amazonses.com.
