#7441: Doctest OutputChecker for xml and json
---------------------------------------+------------------------------------
          Reporter:  leosoto           |         Owner:  nobody
            Status:  reopened          |     Milestone:        
         Component:  Unit test system  |       Version:  SVN   
        Resolution:                    |      Keywords:  jython
             Stage:  Accepted          |     Has_patch:  1     
        Needs_docs:  0                 |   Needs_tests:  0     
Needs_better_patch:  0                 |  
---------------------------------------+------------------------------------
Changes (by leosoto):

  * status:  closed => reopened
  * resolution:  fixed =>

Comment:

 Seems that the `looks_like_markup` method was a premature optimization
 which are doing more harm that good. On
 source:django/trunk/tests/regressiontests/admin_widgets/models.py there
 are doctest output like:
 e
 {{{
 Currently: <a target="_blank" href="%(MEDIA_URL)stest">test</a> <br
 />Change: <input type="file" name="test" />
 }}}

 So I think we have to drop that (the `repr_re` hack also not very good,
 raising false negatives with every attribute value containing "at" or
 "object".

 Also the "wrapper" strategy to check xml fragments was dropped from the
 patch when it was committed to trunk, but it is needed for cases like the
 shown above.

 I'm attaching a patch fixing these two issues.

-- 
Ticket URL: <http://code.djangoproject.com/ticket/7441#comment:6>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to