#32511: Deferred fields incorrect when following prefetches back to the "parent"
object
-------------------------------------+-------------------------------------
Reporter: Jamie Matthews | Owner: Jamie
| Matthews
Type: Bug | Status: closed
Component: Database layer | Version: 3.1
(models, ORM) |
Severity: Normal | Resolution: fixed
Keywords: | Triage Stage: Ready for
| checkin
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Sarah Boyce <42296566+sarahboyce@…>):
In [changeset:"198b30168d4e94af42e0dc7967bd3259b5c5790b" 198b301]:
{{{#!CommitTicketReference repository=""
revision="198b30168d4e94af42e0dc7967bd3259b5c5790b"
Fixed #36135 -- Fixed reverse GenericRelation prefetching.
The get_(local|foreign)_related_value methods of GenericRelation must be
reversed because it defines (from|to)_fields and associated related_fields
in the reversed order as it's effectively a reverse GenericForeignKey
itself.
The related value methods must also account for the fact that referenced
primary key values might be stored as a string on the model defining the
GenericForeignKey but as integer on the model defining the
GenericRelation.
This is achieved by calling the to_python method of the involved content
type
in get_foreign_related_value just like GenericRelatedObjectManager does.
Lastly reverse many-to-one manager's prefetch_related_querysets should use
set_cached_value instead of direct attribute assignment as direct
assignment
might are disallowed on ReverseManyToOneDescriptor descriptors. This is
likely
something that was missed in f5233dc (refs #32511) when the is_cached
guard
was added.
Thanks 1xinghuan for the report.
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/32511#comment:6>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/01070194cb2db857-188d11e9-e109-4a3a-b2f3-54503e5f27a2-000000%40eu-central-1.amazonses.com.
