#36284: Related lookup popup doesn't close after selecting an existing item
--------------------------------------+------------------------------------
Reporter: Matthias Kestenholz | Owner: (none)
Type: Bug | Status: new
Component: contrib.admin | Version: 5.2
Severity: Release blocker | Resolution:
Keywords: RelatedObjectLookups | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 1
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Matthias Kestenholz):
Thanks! Yep, I totally agree.
The `RelatedObjectLookups.js` exposes many functions directly on `window`
and exposing the additional variable doesn't seem worse than what we have
now; I borrowed the variable name from React to make it very obvious that
this is a hack and I don't like it much.
I think the cleanest solution would be to rewrite the related object
lookups test from QUnit to selenium and keeping `relatedWindows` as a
module-level `const` variable without exposing it. We could avoid exposing
`relatedWindows` so that QUnit can access it. This will need some work
though!
--
Ticket URL: <https://code.djangoproject.com/ticket/36284#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/01070195f1dc05df-b829a138-5317-4169-835b-6d16b228c7e4-000000%40eu-central-1.amazonses.com.
