#35353: SelectFilter2.js puts the label for Django Admin filter fields in the 
wrong
place
-------------------------------+--------------------------------------
     Reporter:  Phil Gyford    |                    Owner:  nobody
         Type:  Bug            |                   Status:  new
    Component:  contrib.admin  |                  Version:  5.0
     Severity:  Normal         |               Resolution:
     Keywords:                 |             Triage Stage:  Unreviewed
    Has patch:  0              |      Needs documentation:  0
  Needs tests:  0              |  Patch needs improvement:  0
Easy pickings:  0              |                    UI/UX:  1
-------------------------------+--------------------------------------
Changes (by Zbigniew Skowron):

 * resolution:  worksforme =>
 * status:  closed => new

Comment:

 This is a bug in `django/contrib/admin/static/admin/js/SelectFilter2.js`.
 This code in `SelectFilter2.js` puts the widget before the label:

 {{{
             // Make sure the selector div is at the beginning so that the
             // add link would be displayed to the right of the widget.
             from_box.parentNode.prepend(selector_div);
 }}}

 It works only if `RelatedFieldWidgetWrapper` is used, as the wrapper puts
 the widget inside a separate `<div>`, so `prepend()` doesn’t reorder
 widget with respect to the label.
 Without the `RelatedFieldWidgetWrapper` we get the bug.
-- 
Ticket URL: <https://code.djangoproject.com/ticket/35353#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/01070196fc405ded-5be8e1ec-b16d-4d86-8445-d00a7825e823-000000%40eu-central-1.amazonses.com.

Reply via email to