#34322: ManifestStaticFilesStorage crashes on commented JavaScript import
statements
-------------------------------------+-------------------------------------
Reporter: Adam Johnson | Owner: Mariusz
| Felisiak
Type: Bug | Status: closed
Component: contrib.staticfiles | Version: 4.2
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by blighj):
I've put together a [https://github.com/django/django/pull/19551 PR 19551]
to use JsLex as per Adam's suggestion in comment:17
It seems to work quite well, the tests are all passing and it seems a more
robust approach to the problem. Takes care of the issues with comments and
some of the other edge cases that the regexes was struggling with. I've
left in the optin behaviour of the current implenetation, but with enough
feedback we could consider making it the default.
I'm not sure on the etiquette of associating a PR with a closed ticket.
Let me know if I need to do something differently there.
--
Ticket URL: <https://code.djangoproject.com/ticket/34322#comment:32>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/010701975e1f086e-d608ee92-eb55-495d-a8b5-dfbaf63bd59c-000000%40eu-central-1.amazonses.com.
