#36112: DatabaseOperations.format_debug_sql() crashes when query fails to execute on some backends -----------------------------------+-------------------------------------- Reporter: Jacob Walls | Owner: Tim Graham Type: Bug | Status: assigned Component: Testing framework | Version: dev Severity: Release blocker | Resolution: Keywords: | Triage Stage: Accepted Has patch: 0 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 0 Easy pickings: 0 | UI/UX: 0 -----------------------------------+-------------------------------------- Comment (by Natalia Bidart):
I believe my work from ticket #36380 (https://github.com/django/django/pull/19512) solves the reported crash since `format_debug_sql` is no longer called on the result of `last_executed_query`. The new `SQLFormatter` would only call `format_debug_sql` for truthy values of SQL, so, strictly speaking, the ticket would be solved. Though, I understand that there is a desire to make further improvements to `last_executed_query`, in that case, we could downgrade this ticket to not-release-blocker and repurpose it. What do you all think? -- Ticket URL: <https://code.djangoproject.com/ticket/36112#comment:8> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To unsubscribe from this group and stop receiving emails from it, send an email to django-updates+unsubscr...@googlegroups.com. To view this discussion visit https://groups.google.com/d/msgid/django-updates/0107019769694d37-cfb4f523-b798-48dc-8e50-a8687b529f38-000000%40eu-central-1.amazonses.com.