#36518: full_clean crashes on model with both a CheckConstraint and a
GeneratedField with a Case expression
-------------------------------------+-------------------------------------
     Reporter:  Olivier Dalang       |                    Owner:  Simon
                                     |  Charette
         Type:  Bug                  |                   Status:  assigned
    Component:  Database layer       |                  Version:  5.2
  (models, ORM)                      |
     Severity:  Release blocker      |               Resolution:
     Keywords:                       |             Triage Stage:  Accepted
    Has patch:  1                    |      Needs documentation:  1
  Needs tests:  1                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  0
-------------------------------------+-------------------------------------
Changes (by Sarah Boyce):

 * has_patch:  0 => 1
 * needs_docs:  0 => 1
 * needs_tests:  0 => 1

Comment:

 > Looking back at ​the proposed patch it seems like it would be adequate
 to address this issue even if it duplicates `sql.Query.build_filter logic`
 as we likely want to avoid also backporting a refactor. It would keep the
 unnecessary work in performed by `_get_field_expression_map` though.

 I agree the solution for #34871 is backportable and likely preferable to a
 deeper refactor, would you mind adding a test to that patch relating to
 this ticket and a release note?
-- 
Ticket URL: <https://code.djangoproject.com/ticket/36518#comment:7>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/010701986070824b-c8488016-ef74-4558-b7da-12084b93211a-000000%40eu-central-1.amazonses.com.

Reply via email to