#8203: File Storage can't delete temporary uploaded files in Windows
-------------------------------------------+--------------------------------
Reporter: julien | Owner: nobody
Status: new | Milestone: 1.0
Component: File uploads/storage | Version: SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 1
Needs_better_patch: 1 |
-------------------------------------------+--------------------------------
Comment (by snaury):
rajeshdhawan, in my humble opinion closing a file before moving it is
wrong and unstable, besides it relies on the incorrect behaviour of
django.core.files.temp.NamedTemporaryFile (which my patch fixes as well).
shutil.move is just totally unreliable: it has no concept of
allow_overwrite, and it might accidentally destroy files, so django should
not use it like that. If you worry my implementation is still lacking some
bits of shutil I'm attaching a new patch that has _samefile and copyfile
copied from shutil.
--
Ticket URL: <http://code.djangoproject.com/ticket/8203#comment:17>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
