#36441: Add lazy loading support for GDAL library in `django.contrib.gis.gdal`
-------------------------------------+-------------------------------------
Reporter: Josh Thomas | Owner: Josh
Type: | Thomas
Cleanup/optimization | Status: assigned
Component: GIS | Version: dev
Severity: Normal | Resolution:
Keywords: gdal | Triage Stage: Accepted
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Josh Thomas):
* needs_better_patch: 1 => 0
Comment:
Ah! Thanks for the heads up. That came up in a review from @benjaoming and
I accepted the suggestion without thinking about the import. I've fixed
the import and rebased to the most recent changes on main.
Replying to [comment:7 Brad Stricherz]:
> I reviewed PR #19529 and ran the new GDAL lazy-loading tests locally.
With PostGIS configured and GDAL missing, django.setup() no longer errors,
and the tests in gis_tests.gdal_tests.tests pass.
>
> There is a missing import in django/contrib/gis/gdal/driver.py:
>
>
> {{{
> NameError: name 'classproperty' is not defined
> }}}
>
>
> This can be fixed by adding:
>
>
> {{{
> from django.utils.functional import classproperty
> }}}
>
>
>
> Once that is corrected, the patch should be ready for checkin. Marking
as Patch needs improvement until the import is added.
--
Ticket URL: <https://code.djangoproject.com/ticket/36441#comment:8>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/01070199e0d3cf41-0990370c-21bd-4479-b481-e4233412491c-000000%40eu-central-1.amazonses.com.
