#8479: Race condition in core.files.storage.py, leads to crash
----------------------------+-----------------------------------------------
 Reporter:  aubonbeurre     |       Owner:  nobody    
   Status:  new             |   Milestone:  1.0       
Component:  Core framework  |     Version:  SVN       
 Keywords:                  |       Stage:  Unreviewed
Has_patch:  1               |  
----------------------------+-----------------------------------------------
 This seems related to #4948, but not quite, so I opened a new ticket.

 Line 148:

                 # This file has a file path that we can move.
                 if hasattr(content, 'temporary_file_path'):
                     file_move_safe(content.temporary_file_path(),
 full_path)
                     content.close()

 This should be inverted:

                 # This file has a file path that we can move.
                 if hasattr(content, 'temporary_file_path'):
                     content.close()
                     file_move_safe(content.temporary_file_path(),
 full_path)

 The code throws an exception, because it ends-up to copy-then-delete,
 since in my particular case src and dest are not on the same file system.

 It will fail on Windows, and I suspect this is particular to NTFS
 (although I did not test on other platforms): it is not possible to remove
 an opened file.

-- 
Ticket URL: <http://code.djangoproject.com/ticket/8479>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to