#36740: Replace MANIFEST.in with setuptools configuration via pyproject.toml
--------------------------------------+------------------------------------
Reporter: Pravin | Owner: Pravin
Type: Cleanup/optimization | Status: assigned
Component: Packaging | Version: dev
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
--------------------------------------+------------------------------------
Comment (by Pravin):
Replying to [comment:2 Jacob Walls]:
> Tentatively accepting.
>
> Please focus first on producing a build that differs in no way from our
existing manifest. Please include a before and after manifest of the
packaged files with the PR. Then in subsequent commits we can make tweaks,
e.g. to remove the scripts directory, see
[https://forum.djangoproject.com/t/avoid-packaging-scripts-folder/43296
forum].
Before raising PR I want to notify you something:
- Currently what i have noticed that we can't remove the non-package
folders (like tests, js_tests, extras, scripts) from MANIFEST.in . They
are removable if we include them under data-files table in pyproject.toml.
but they don't recursively add subfolders inside them. for example. in
case of tests , even if i mentioned [["tests/**/*"]] , the subfolder like
_ext, _theme were not able to get copied. so instead of simplifying it was
getting complex since i had to include subfolders explicitly.
- I cleanup the manifest file which reduced the redundant things.
- i have tested the original and modified build and **there is no
differs.**
- final MANIFEST.in looks like this
-
{{{
graft tests
graft docs
graft js_tests
graft extras
graft scripts
global-exclude *.py[co]
}}}
So what's your take on this ? Should I proceed further in submitting the
request ?
--
Ticket URL: <https://code.djangoproject.com/ticket/36740#comment:4>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019a9baa2e90-fa2d7e32-c392-4a71-9650-c31a5be4a7cc-000000%40eu-central-1.amazonses.com.
