#36144: DatabaseOperations.bulk_batch_size() should consider more database
limits
on SQLite and Oracle
-------------------------------------+-------------------------------------
Reporter: Sarah Boyce | Owner: (none)
Type: | Status: new
Cleanup/optimization |
Component: Database layer | Version: 5.2
(models, ORM) |
Severity: Normal | Resolution:
Keywords: | Triage Stage: Accepted
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Comment (by Pravin):
Hi all,
I tried to produce the failure. I have created relatively large complex
model setup.
{{{
class CompositePKModel(models.Model):
part1 = models.IntegerField()
part2 = models.IntegerField()
value1 = models.IntegerField(default=0)
value2 = models.IntegerField(default=0)
value3 = models.IntegerField(default=0)
flag = models.BooleanField(default=False)
class Meta:
constraints = [
models.UniqueConstraint(fields=["part1", "part2"],
name="pk_cmp")
]
class RelatedModel(models.Model):
parent = models.ForeignKey(CompositePKModel, on_delete=models.CASCADE)
score1 = models.IntegerField(default=0)
score2 = models.IntegerField(default=0)
active = models.BooleanField(default=False)
class AnotherRelatedModel(models.Model):
parent = models.ForeignKey(RelatedModel, on_delete=models.CASCADE)
rating = models.IntegerField(default=0)
status = models.BooleanField(default=True)
}}}
{{{
class BulkUpdateComplexTest(TestCase):
databases = {"default"}
@classmethod
def setUpTestData(cls):
cls.parents = [
CompositePKModel(part1=i, part2=i + 1)
for i in range(800)
]
CompositePKModel.objects.bulk_create(cls.parents)
cls.related_objs = []
for parent in cls.parents:
for j in range(3):
cls.related_objs.append(
RelatedModel(parent=parent)
)
RelatedModel.objects.bulk_create(cls.related_objs)
cls.another_related_objs = []
for rel in cls.related_objs:
for k in range(2):
cls.another_related_objs.append(
AnotherRelatedModel(parent=rel)
)
AnotherRelatedModel.objects.bulk_create(cls.another_related_objs)
def test_bulk_update_multiple_models(self):
for obj in self.parents:
obj.value1 = 111
obj.value2 = 222
obj.value3 = 333
obj.flag = True
for obj in self.related_objs:
obj.score1 = 10
obj.score2 = 20
obj.active = True
for obj in self.another_related_objs:
obj.rating = 5
obj.status = False
try:
with transaction.atomic():
CompositePKModel.objects.bulk_update(
self.parents, ['value1', 'value2', 'value3', 'flag']
)
RelatedModel.objects.bulk_update(
self.related_objs, ['score1', 'score2', 'active']
)
AnotherRelatedModel.objects.bulk_update(
self.another_related_objs, ['rating', 'status']
)
except OperationalError as e:
self.fail(f"bulk_update failed due to SQLite expression depth:
{e}")
self.assertTrue(all(o.value1 == 111 for o in
CompositePKModel.objects.all()))
self.assertTrue(all(o.score1 == 10 for o in
RelatedModel.objects.all()))
self.assertTrue(all(o.rating == 5 for o in
AnotherRelatedModel.objects.all()))
}}}
am i missing something ?
--
Ticket URL: <https://code.djangoproject.com/ticket/36144#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019acf4c77db-031c52ac-db9f-4bbb-b8fc-3bb3930849bf-000000%40eu-central-1.amazonses.com.
