#36829: Breaking change in ClearableFileInput
---------------------------------+--------------------------------------
Reporter: Johannes Maron | Owner: (none)
Type: Bug | Status: new
Component: Forms | Version: 6.0
Severity: Release blocker | Resolution:
Keywords: | Triage Stage: Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 1
---------------------------------+--------------------------------------
Description changed by Johannes Maron:
Old description:
> Howdy y'all,
>
> #35892 flipped `django.forms.widgets.ClearableFileInput.use_fieldset`
> from false to true.
>
> This changes the form rendering outside the admin too. Probably just a
> small oversight and not an intentional change, since changes weren't
> accompanied by release notes.
>
> Anyhow, both the input and the `use_fieldset` are part of the public
> documentation, and changes must undergo deprecation.
>
> The problem gets amplified with #36828, since the current fieldset
> implementation violates HTML and WCAG 2.1
>
> The only affected version is 6.0. I would recommend providing a
> regression patch in the next bugfix release.
>
> Cheers!
> Joe
New description:
Howdy y'all,
#35892 flipped `django.forms.widgets.ClearableFileInput.use_fieldset` from
false to true.
The change can be found here:
https://github.com/django/django/blame/4187da258fe212d494cb578a0bc2b52c4979ab95/django/forms/widgets.py#L533
This changes the form rendering outside the admin too. Probably just a
small oversight and not an intentional change, since changes weren't
accompanied by release notes.
Anyhow, both the input and the `use_fieldset` are part of the public
documentation, and changes must undergo deprecation.
The problem gets amplified with #36828, since the current fieldset
implementation violates HTML and WCAG 2.1
The only affected version is 6.0. I would recommend providing a regression
patch in the next bugfix release.
Cheers!
Joe
--
--
Ticket URL: <https://code.djangoproject.com/ticket/36829#comment:1>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019b5b5ca752-3a49dbda-879f-4efe-b2b6-b2c5b9c7cb95-000000%40eu-central-1.amazonses.com.
