#36836: Add version identification to Redis cache backend
-------------------------------------+-------------------------------------
Reporter: Vasil Chomakov | Owner: (none)
Type: New feature | Status: closed
Component: Core (Cache system) | Version: dev
Severity: Normal | Resolution: wontfix
Keywords: | Triage Stage:
| Unreviewed
Has patch: 1 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
Changes (by Simon Charette):
* resolution: => wontfix
* status: new => closed
Comment:
Django only uses the `redis` package for providing a caching backend so it
seems inapropriate to override the `lib_name` and `lib_version` that
`redis-py` already sets by itself.
Per [https://redis.io/docs/latest/commands/client-setinfo/ Redis docs]
> `lib-name` - meant to hold the name of the client library that's in use.
{{{#!python
(Pdb) pp client.client_info()
{...
'lib-name': 'redis-py',
'lib-ver': '7.1.0',
...
}
}}}
Moreover it seems that `redis.Connection(lib_name)` and `lib_info`
[https://github.com/redis/redis-
py/blob/796428825dd33459b63228d274becc1c217589d1/redis/client.py#L294-L297
are deprecated] so we'd want to use `driver_info` instead.
If we were to change change `lib_name` I think it should be along the
lines of `redis-py(django-cache)` as these connections are only meant to
be used for this purpose but just like each new feature
[https://docs.djangoproject.com/en/6.0/internals/contributing/bugs-and-
features/#requesting-features this should be proposed and discussed first
per the documented process].
--
Ticket URL: <https://code.djangoproject.com/ticket/36836#comment:3>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019b6aa983a1-2b0eb907-0558-42b2-8215-3e0050253e8d-000000%40eu-central-1.amazonses.com.
