#34643: Move admin form labels to a more accessible place
-------------------------------------+-------------------------------------
     Reporter:  Tom Carrick          |                    Owner:  Antoliny
         Type:                       |                   Status:  assigned
  Cleanup/optimization               |
    Component:  contrib.admin        |                  Version:  dev
     Severity:  Normal               |               Resolution:
     Keywords:  accessibility        |             Triage Stage:  Ready for
                                     |  checkin
    Has patch:  1                    |      Needs documentation:  0
  Needs tests:  0                    |  Patch needs improvement:  0
Easy pickings:  0                    |                    UI/UX:  1
-------------------------------------+-------------------------------------
Changes (by Jacob Walls):

 * stage:  Accepted => Ready for checkin

Comment:

 There are a few `.form-row.errors` selectors that are now superfluous and
 can be removed, but otherwise this is ready to ship, I think.

 {{{#!diff
 diff --git a/django/contrib/admin/static/admin/css/base.css
 b/django/contrib/admin/static/admin/css/base.css
 index 753457e7ee..a820979a25 100644
 --- a/django/contrib/admin/static/admin/css/base.css
 +++ b/django/contrib/admin/static/admin/css/base.css
 @@ -727,17 +727,6 @@ td ul.errorlist li {
      margin: 0;
  }

 -.form-row.errors {
 -    margin: 0;
 -    border: none;
 -    border-bottom: 1px solid var(--hairline-color);
 -    background: none;
 -}
 -
 -.form-row.errors ul.errorlist li {
 -    padding-left: 0;
 -}
 -
  .errors input, .errors select, .errors textarea,
  td ul.errorlist + input, td ul.errorlist + select, td ul.errorlist +
 textarea {
      border: 1px solid var(--error-fg);
 }}}
-- 
Ticket URL: <https://code.djangoproject.com/ticket/34643#comment:37>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion visit 
https://groups.google.com/d/msgid/django-updates/0107019c95346d85-e631b4dd-6eac-44d2-a492-93d4c2287014-000000%40eu-central-1.amazonses.com.

Reply via email to