#36960: Django never uses psycopg 3's optimised timestamptzloader
-------------------------------------+-------------------------------------
Reporter: Aarni Koskela | Type: Bug
Status: new | Component: Database
| layer (models, ORM)
Version: 6.0 | Severity: Normal
Keywords: postgresql | Triage Stage:
| Unreviewed
Has patch: 0 | Needs documentation: 0
Needs tests: 0 | Patch needs improvement: 0
Easy pickings: 0 | UI/UX: 0
-------------------------------------+-------------------------------------
When available (e.g. `psycopg3-c` or `psycopg3-binary` installed), Psycopg
implicitly registers a faster `TimestamptzLoader` implementation
[https://github.com/psycopg/psycopg/blob/master/psycopg_c/psycopg_c/types/datetime.pyx].
However, Django overrides this with a custom class that derives from the
Python `psycopg.types.datetime.TimestamptzLoader` implementation. (You
can't derive from the `final`-marked C speedup class, anyway.)
For performance, it would be pleasant if Django used the faster class when
available. This is made slightly hairy by the fact that, as mentioned, you
can't use the speedup class as a base, and there is no public API in
psycopg to get the speedup class. `context.adapters._get_optimised`
exists, but is not a public API. You could do something like (and I
experimentally did)
{{{
try:
optimised_class =
context.adapters._get_optimised(TimestamptzLoader)
if optimised_class is not TimestamptzLoader:
self.fast_load = optimised_class(oid,
context).load
except Exception:
pass
}}}
and `res = (self.fast_load or super().load)(data)` but that's also
hairy...
--
Ticket URL: <https://code.djangoproject.com/ticket/36960>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion visit
https://groups.google.com/d/msgid/django-updates/0107019ca037fdb6-f5f75ddb-aebf-4db3-b0c2-d0a38066d783-000000%40eu-central-1.amazonses.com.
