#8359: Adding a user in admin doesn't create a LogEntry for the addition
----------------------------------------+-----------------------------------
Reporter: evan_schulz | Owner: nobody
Status: closed | Milestone: 1.0
Component: Admin interface | Version: SVN
Resolution: fixed | Keywords:
Stage: Ready for checkin | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
----------------------------------------+-----------------------------------
Comment (by [EMAIL PROTECTED]):
Replying to [comment:5 mtredinnick]:
> The second patch should go into a new ticket and we can consider that
after 1.0. It's a feature addition, since it restricts the choices on the
actions available in the !LogEntry model, which may or may not be what we
want to do.
This is a weak decision. First off, the bug as submitted is not entirely
fixed without the second patch since the logentry for the user addition
still does not show up as an addition in the object history. Second, the
choices on the action_flag are already restricted to a
SmallPositiveInteger. If you are seriously concerned about restricting the
values, you need to change this to an IntegerField at the very least.
Third, set theory suggests that the defined actions -- addition, deletion
and change -- are all of the possible actions available for any object.
There are no other choices that would not logically overlap the available
choices. If you want to argue that set theory is incomplete and new types
of state transitions that are not changes or additions or deletions may be
discovered someday, then your comment is valid. Otherwise it simply
perpetuates a wart that is trivially fixed as my patch demonstrates.
--
Ticket URL: <http://code.djangoproject.com/ticket/8359#comment:7>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
