#8197: Update Polish administrative entites
---------------------------------------------------------------+------------
Reporter: Piotr Lewandowski <[EMAIL PROTECTED]> | Owner:
nobody
Status: reopened | Milestone:
Component: django.contrib.localflavor | Version:
SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch:
0
Needs_docs: 0 | Needs_tests:
0
Needs_better_patch: 0 |
---------------------------------------------------------------+------------
Comment (by Piotr Lewandowski <[EMAIL PROTECTED]>):
`pl_regions.py` has serveral advantages over current state:
- it merges information from two files into one (`pl_regions.py`) which
is coherent with other localflavors (cl, es, sk, uk). Currently, file
names don't reflect changes from [8345].
- it can be automatically generated what makes future updates easy (see
PolishLocalflavor for details).
- it doesn't use manually crafted key values for `*_CHOICES` tuples so
collisions are unlikely. Currently, there are '''10 duplicates''' in
`ADMINISTRATIVE_UNIT_CHOICES` - it's because there are counties in Poland
with the same name. I can't imagine how this outdated, buggy data could
get into Django 1.0.
- TERYT codes (which are used for keys in `pl_regions.py`) contain
additional information - they enable user to group counties by province
they belong to (it's impossible to do it now). Such possibility would be
very handy - instead confusing user with a counties list which has about
400 items, you can ask him for province in a first place and then show a
list with only ~25 counties.
I'm willing to prepare transition patch (replacing
`pl_administrativeunits.py` and `pl_voivodeships.py` by `pl_regions.py`).
--
Ticket URL: <http://code.djangoproject.com/ticket/8197#comment:6>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---