#8523: contrib.auth's ChangePasswordTest tests have invalid setUp/tearDown
methods
-------------------------------------+--------------------------------------
Reporter: mtrichardson | Owner: cammacrae
Status: closed | Milestone: 1.0
Component: Authentication | Version: SVN
Resolution: wontfix | Keywords:
Stage: Unreviewed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
-------------------------------------+--------------------------------------
Comment (by cammacrae):
Malcolm, you're really splitting hairs to say the patch doesn't address
the ticket - contrib.auth's ChangePasswordTest tests do actually have an
invalid setUp/tearDown methods. The first patch from mtrichardson is
probably correct, but was rejected because the login.html template is
required for tests to pass - neatly overlooking the fact that other
templates are likewise required, but not included in the test template dir
presumably for the reasons outlined in Russell's post. They are included,
by seemingly happy accident, in contrib.admin. My patch addresses the
broken setup method by ensuring that the tests can still pass in the
absence of contrib.admin.
On the issue of the order of template directory resolution I'd agree with
you if the templates used in the test were in fact standard templates for
contrib.auth, but they're not: they're specific test templates (broken as
that is).
As for the bonus, you're right & I knew you were right the second I
uploaded the patch.
--
Ticket URL: <http://code.djangoproject.com/ticket/8523#comment:8>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
