#8643: Misleading comments in django.http.multipartparser.py ---------------------------+------------------------------------------------ Reporter: KayEss | Owner: nobody Status: new | Milestone: Component: Uncategorized | Version: SVN Keywords: | Stage: Unreviewed Has_patch: 1 | ---------------------------+------------------------------------------------ There are a number of comments in the file presumably left over from before the refactoring work. The patch simply removes some and rewords a few others.
* The input data is not a bytestring, it's a file. See [http://www.kirit.com/Blog:/2008-08-28/Multipart%20form%20problems%20with%20PyISAPIe%20and%20Django my web site for a StringIO example]. * file_upload_dir isn't mentioned anywhere apart from in the comment. I guess that the upload handlers are now meant to deal with this. The upload parser does also seem to be missing some error handling. It doesn't appear to check that it has parsed the same number of bytes as the specified content length and it certainly doesn't throw any sort of error if the input data is empty. The patch is against r8047. -- Ticket URL: <http://code.djangoproject.com/ticket/8643> Django Code <http://code.djangoproject.com/> The web framework for perfectionists with deadlines --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-updates?hl=en -~----------~----~----~----~------~----~------~--~---
