#7140: Errors in escaping fieldnames in Oracle
--------------------------------------------+-------------------------------
Reporter: [EMAIL PROTECTED] | Owner: mboersma
Status: assigned | Milestone: 1.0
Component: Database wrapper | Version: SVN
Resolution: | Keywords: qsrf-cleanup
oracle, quote, escape
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 1
Needs_better_patch: 0 |
--------------------------------------------+-------------------------------
Comment (by mboersma):
I've been reviewing this, and I can say at least the patch does no harm--
no tests break. But I've been trying to create a test case to see that it
actually fixes the stated problem: that specifying db_table =
'"schema.tablename"' works ok. My approach was to create a queryset, call
qs.query.as_sql(), then change the Model._meta.db_table, create a new
queryset and call qs.query.as_sql again. (It's a finicky test, but I
special-cased it only to run on Oracle in the queries test suite.)
Unfortunately, in the second test I get something like:
SELECT "schema.tablename"."colname" FROM ....
which Oracle won't like.
So I'm not currently able to verify it fixes the problem. And given that
the proper solution awaits in #6148 as Ian Kelly mentions, I'll have to
say thumbs down for now.
(But I have plenty of time this weekend to attend to Django, so if someone
has a strong argument for thumbs up, I will be glad to dig into this
tomorrow.)
--
Ticket URL: <http://code.djangoproject.com/ticket/7140#comment:9>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
