#8562: OneToOnes + primary_key = True ... fails in Admin
--------------------------------------+-------------------------------------
Reporter: magneto | Owner: brosner
Status: assigned | Milestone: 1.0
Component: Admin interface | Version: SVN
Resolution: | Keywords: admin onetoone
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 1
Needs_better_patch: 1 |
--------------------------------------+-------------------------------------
Comment (by brosner):
Ok, I am a bit confused here. The conditional check in ```add_fields``` is
wrong. The only time the field needs to be marked as hidden is if it were
created by Django period. Any other cases need to be given UI. I also
don't understand why ```unique``` is playing a role here. It seems the
real issue is the data is not being mapped correctly by
```model_to_dict``` and that fix in the patch is technically wrong too.
There should be no need to map the data twice to work around problem. Sure
looks like symptom patching there. In #8241 semenov brings up a point
about the use of ```attname``` and he is correct. We shouldn't be stomping
on that namespace like that. With a fix to that it sounds like this ticket
would be correctly fixed. Please explain a bit more why the stuff in
```add_fields``` is needed. Thanks.
--
Ticket URL: <http://code.djangoproject.com/ticket/8562#comment:13>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
