#8713: Django core depends on django.contrib
---------------------------------------------------------------+------------
Reporter: Piotr Lewandowski <[EMAIL PROTECTED]> | Owner:
nobody
Status: new | Milestone:
Component: Uncategorized | Version:
SVN
Resolution: | Keywords:
Stage: Unreviewed | Has_patch:
0
Needs_docs: 0 | Needs_tests:
0
Needs_better_patch: 0 |
---------------------------------------------------------------+------------
Comment (by Piotr Lewandowski <[EMAIL PROTECTED]>):
== Backwards compatibile issues ==
=== `tests/client.py` ===
Presence of `django.contrib.session` in `INSTALLED_APPS` is __mostly__
checked before import. It can be done with `django.contrib.auth` as well,
which is actually used only in `Client.login()` method. Or at least
relevant import could be just moved to this method (ugly).
=== `db/models/sql/subqueries.py` ===
`django.contrib.contenttypes` is used in
`DeleteQuery.delete_batch_related()` method. At least a check in
`INSTALLED_APPS` could be done.
=== `core/management/commands/cleanup.py` ===
Move this command to `django/contrib/session/management/commands/`.
=== `core/management/sql.py` ===
Import is present but not used. Remove it.
=== `views/defaults.py` ===
Additional check for `django.contrib.contenttypes` and
`django.contrib.sites` in `INSTALLED_APPS`.
== Backwards incompatible issues ==
=== `django/db/models/fields/__init__.py` ===
Covered by #8210 and #8664.
=== `views/generic/create_update.py` ===
`create_object()` should not have `login_required` argument.
`django.contrib.auth.decorators.login_required` should be used instead.
=== `core/context_processors.py` ===
Move `django.core.context_processors.auth` to
`django.contrib.auth.context_processsors`.
== No issues ==
=== `db/models/base.py` ===
`django.contrib` used only in a comment.
=== `middleware/cache.py` ===
`django.contrib` used only in an assertion string.
--
Ticket URL: <http://code.djangoproject.com/ticket/8713#comment:4>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---