#8210: USStateField should be moved to django.contrib.localflavor.us
---------------------------------------------------------------+------------
Reporter: Piotr Lewandowski <[EMAIL PROTECTED]> | Owner:
nobody
Status: new | Milestone:
1.0
Component: Database wrapper | Version:
SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch:
1
Needs_docs: 0 | Needs_tests:
0
Needs_better_patch: 0 |
---------------------------------------------------------------+------------
Comment (by jacob):
Replying to [comment:7 mattmcc]:
> Some decisions I didn't make:
>
> * The Person model in docs/topics/db/models.txt uses a
models.USStateField. Leaving it in the example without an import line may
cause confusion, but it feels wrong to have the import in a code fragment
of that sort.
Please add a fix for this in the patch; just throw the import at the top
of the code snippet.
> * db.backends.*.creation defines a [var]char field for USStateField.
Should this now be handled by the field itself via db_type, and the entry
removed from the creation modules?
Yes; please add it to the patch.
> * gis.utils.layermapping maps a USStateField, but may not care about it
after the field is no longer in the default django.db.models.fields
collection.
It's fine to leave this alone; Justin can clean it up if it bugs him.
--
Ticket URL: <http://code.djangoproject.com/ticket/8210#comment:9>
Django Code <http://code.djangoproject.com/>
The web framework for perfectionists with deadlines
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---