#9068: InsertQuery.clone typo?
------------------------------------------+---------------------------------
 Reporter:  rush                          |       Owner:  nobody    
   Status:  new                           |   Milestone:            
Component:  Database layer (models, ORM)  |     Version:  1.0       
 Keywords:                                |       Stage:  Unreviewed
Has_patch:  0                             |  
------------------------------------------+---------------------------------
 Hello, I think there's a typo in django/db/models/sql/subqueries.py:296

 {{{
 return super(InsertQuery, self).clone(klass, extras)
 }}}

 instead of

 {{{
 return super(InsertQuery, self).clone(klass, **extras)
 }}}

 Please also consider this modification for better subclassing

 {{{
     def clone(self, klass=None, **kwargs):
         extras = {'columns': self.columns[:], 'values': self.values[:],
                 'params': self.params}
         extras.update(kwargs)
         return super(InsertQuery, self).clone(klass, **extras)
 }}}

-- 
Ticket URL: <http://code.djangoproject.com/ticket/9068>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to