#8630: Improve the comments framework customizability
----------------------------------------------+-----------------------------
Reporter: thejaswi_puthraya | Owner: carljm
Status: new | Milestone:
Component: django.contrib.comments | Version: SVN
Resolution: | Keywords: comments,
customization
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 1
Needs_better_patch: 0 |
----------------------------------------------+-----------------------------
Comment (by carljm):
Ok, this patch is ready for a looking-over by someone who knows what
they're doing. This is my first time trying to actually write any Django
docs, so feedback and suggestions are welcome.
A couple other notes on decisions I made in the patch:
- I took Thejaswi's approach of modifying contrib.comments' get_model()
etc functions to be smart about delegating to a custom COMMENTS_APP. To
me, this seems cleanest, as no other code (ie the templatetags) has to
duplicate the get_comment_app() song and dance, it all happens in one
place.
- I also incorporated amir's suggestion to make all the customization
functions optional, so you can customize what you like and leave the rest.
- No tests yet. I'm not clear where to go with this, as contrib.comments
has no tests at all currently. Should I be writing tests for the whole
app as part of this ticket? (Seems like maybe that should be its own
ticket). Should I just introduce some simple tests for the
customizability, and leave everything else untested?
Thoughts and feedback welcome.
--
Ticket URL: <http://code.djangoproject.com/ticket/8630#comment:11>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
