#4604: Message Passing For Anonymous Users --------------------------------------------------------------+------------- Reporter: Sean Patrick Hogan <[EMAIL PROTECTED]> | Owner: SmileyChris Status: new | Milestone: Component: Contrib apps | Version: SVN Resolution: | Keywords: Stage: Accepted | Has_patch: 1 Needs_docs: 0 | Needs_tests: 0 Needs_better_patch: 1 | --------------------------------------------------------------+------------- Comment (by SmileyChris):
Replying to [comment:63 mtredinnick]: > Moving back from "ready for checkin", because I don't think it is yet. I suspect the new `lazy()` from r8120 is probably more reusable here. The duplicate lazy stuff makes me nervous. That's fine - back when I started `lazy()` didn't do a very good job. > I don't like the backwards compatibility this brings to the table. This is probably something that's relatively orthogonal to the existing stuff. I'm also not wild about it being in core, rather than a contrib app, since whilst it's useful sometimes and meets the "a reasonably common pattern", it's hardly impossible to use Django without it. It's only "in core" as much as the auth context processor is. And that is only required if you want messages and aren't using the auth context processor. I guess it could have it's own contrib app but it would only consist of a context processor! > Solve the backwards incompatibility problem (not breaking existing admin, particularly) What backwards incompatibility? It won't break existing admin. > ... and work out how it could be part of contrib somewhere (contrib/auth maybe?) and it will have a better chance or proceeding. The fact that it impacts contrib/sessions also makes me wonder if the implementation is really correct. The whole point is that this is a session message system. It seems obvious to bake it into contrib/sessions to me. The context processor just provides a single message context variable containing both (existing) user messages and (new) session messages. This keeps backwards compatibility with the current message system (and admin). However, as it has been noted [http://code.djangoproject.com/ticket/4604#comment:56 by tobias], the admin is currently doing the wrong thing and should really be updated to using a session based messaging system. -- Ticket URL: <http://code.djangoproject.com/ticket/4604#comment:64> Django <http://code.djangoproject.com/> The Web framework for perfectionists with deadlines. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to django-updates@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-updates?hl=en -~----------~----~----~----~------~----~------~--~---