#9228: Keep SITE_CACHE cache in line with changes to Site instances
-----------------------------------+----------------------------------------
Reporter: Boo | Owner: nobody
Status: new | Milestone: post-1.0
Component: Contrib apps | Version: SVN
Resolution: | Keywords:
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 1
Needs_better_patch: 1 |
-----------------------------------+----------------------------------------
Changes (by mtredinnick):
* needs_better_patch: => 1
* stage: Unreviewed => Accepted
* summary: Simple patch for contrib.sites => Keep SITE_CACHE cache in
line with changes to Site instances
* needs_tests: => 1
* needs_docs: => 0
Comment:
Changed the title to describe the problem being addressed.
This is a good idea, but the implementation needs some work before it can
go in:
* It needs a test. There is a `tests.py` in `django/contrib/sites/`.
* The `save()` method takes a couple of required parameters, not just
`self` (see [http://docs.djangoproject.com/en/dev/ref/models/instances
#saving-objects the Model documentation]).
* To avoid duplicating work, in case we change how things are loaded into
that cache, it will be better to just remove the relevant key from the
`SITE_CACHE` dictionary. Then the next call to `get_current()` will reload
it correctly (whatever "correctly" means now or in the future).
--
Ticket URL: <http://code.djangoproject.com/ticket/9228#comment:1>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
