#9154: Huge improvements in templates rendering
--------------------------------------+-------------------------------------
Reporter: msaelices | Owner: msaelices
Status: new | Milestone:
Component: Template system | Version: SVN
Resolution: | Keywords:
Stage: Unreviewed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
--------------------------------------+-------------------------------------
Comment (by msaelices):
Replying to [comment:9 SmileyChris]:
> Related ticket: #6262
>
> Good things:
> * You're getting the cache templates discussion going again :)
> * Nice catch on the template inheritance problem
>
> Things that need fixing:
> * You're not setting `user_id` under all circumstances in
`django/contrib/admin/templatetags/log.py`
Sorry, I take this from
[http://code.djangoproject.com/attachment/ticket/8110/8110.diff this
patch]. I've fixed that.
> * You can't remove `get_parent()` because the parent template could be
based on a context variable. It needs to be figured out at render time.
You're right. I've fixed that also.
>
> Other considerations:
> * Probably needs a setting to turn off caching if you don't want it. In
fact, it probably should be off by default to keep full backwards
compatibility (introduces the need to reset the server after changing
templates).
I think this change is not a feature change. It's only a optimization. Of
course, I've changed my patch to use {{{settings.TEMPLATE_DEBUG}}} for
turning on/off this caching.
>
> I was thinking that if people were really worried about out-of-date
cached templates then there could be some a cache which compares file size
or date of the file. This would obviously be a slight bit slower and is
out of scope for an initial cut - just writing down my thoughts :)
I think {{{settings.TEMPLATE_DEBUG}}} is enough explicit for developers
that wants automatic template reloads.
--
Ticket URL: <http://code.djangoproject.com/ticket/9154#comment:12>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
