#8968: No way to utilize `next` parameter to redirect after comment deletion
----------------------------------------------+-----------------------------
Reporter: Dzhus | Owner: nobody
Status: new | Milestone:
Component: django.contrib.comments | Version: 1.0
Resolution: | Keywords: comments
Stage: Unreviewed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
----------------------------------------------+-----------------------------
Comment (by neithere):
The little change introduced in the existing patch should apply to all
django.contrib.comments.moderation methods that expect the `next` argument
(which simply can't be in the path as it's a path itself). These methods
are approve(), delete() and flag().
I think that `next=None` should be removed from method signatures, too. In
this case the `next` variable would be undefined in the POST handling
code, so we should either get its value from POST or simply pass
`next=None` to next_redirect() because the latter can get the same data
itself.
Or did I miss something?
(By the way, a non-existent `comment.permalink` is used instead of the
actual `comment.get_absolute_url` in
source:django/trunk/django/contrib/comments/templates/comments/delete.html
and friends. That's a bit off-topic though.)
--
Ticket URL: <http://code.djangoproject.com/ticket/8968#comment:3>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
