#9788: Make user profile a property
------------------------------------------------+---------------------------
Reporter: [EMAIL PROTECTED] | Owner: nobody
Status: reopened | Milestone:
Component: Authentication | Version: 1.0
Resolution: | Keywords:
Stage: Unreviewed | Has_patch: 0
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
------------------------------------------------+---------------------------
Changes (by mtredinnick):
* status: closed => reopened
* resolution: invalid =>
Comment:
Simply on principle, anonymous people shouldn't close tickets and tickets
shouldn't be closed without a reason. There's no way to review the
decision if either of those things happen. I'm reopening so that we might
consider it appropriately.
The attached file has any number of problems that need to be fixed before
we will consider this:
1. It's not a patch. Please don't ask us to rummage through hundreds of
lines of code to find the change you made. Even though you describe the
location in the description, once the file is downloaded, it's no longer
with the description.
2. The change isn't correct (`get_profile` is a method, so the proposed
new property will return a reference to a method).
3. The patch doesn't have tests (which would have revealed the problem in
2).
There are minor points like using descriptor notation (doesn't work in
Python 2.3, so we avoid it) and not having docs, although we can review
the change without the latter.
Is this is only being added to support admin or something? The description
doesn't completely describe the use-case and it's already pretty simple to
filter querysets on the user profile model (since it's a normal reverse
relation).
--
Ticket URL: <http://code.djangoproject.com/ticket/9788#comment:2>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
