#5833: [newforms-admin] Custom FilterSpecs
---------------------------------------------+------------------------------
          Reporter:  Honza_Kral              |         Owner:  jkocherhans      
                                       
            Status:  assigned                |     Milestone:                   
                                       
         Component:  django.contrib.admin    |       Version:  SVN              
                                       
        Resolution:                          |      Keywords:  nfa-someday 
list_filter filterspec nfa-changelist ep2008
             Stage:  Design decision needed  |     Has_patch:  1                
                                       
        Needs_docs:  0                       |   Needs_tests:  0                
                                       
Needs_better_patch:  1                       |  
---------------------------------------------+------------------------------
Changes (by gerdemb):

 * cc: [email protected] (added)

Comment:

 I believe there is a small bug with this patch. Line 31 of
 filterspec_with_custom_queryset_against_1_0.diff should be indented once
 more so that get_field() is only called when a field is defined in the
 list_filter. In the case that the list_filter item is a single callable
 item, the field variable is not set and get_field() should not be called
 for verification.

 Also, any word on if this feature will make it into 1.1? I notice that
 there is no implemented listed on the status page. I'm using this feature
 frequently in my application, and would prefer to run a released version
 of Django instead of patching. :)

-- 
Ticket URL: <http://code.djangoproject.com/ticket/5833#comment:24>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to