#10038: BaseModelFormSet's method save_existing_objects uses form.changed_data
instead of form.has_changed()
---------------------+------------------------------------------------------
 Reporter:  karihre  |       Owner:  nobody    
   Status:  new      |   Milestone:            
Component:  Forms    |     Version:  1.0       
 Keywords:           |       Stage:  Unreviewed
Has_patch:  1        |  
---------------------+------------------------------------------------------
 The method save_existing_objects uses form.changed_data in an if statement
 instead of form.has_changed() (which only does bool(self.changed_data) )
 not enabling people to overload the has_changed() method for custom
 behavior.

 The method save_new_objects in the same class uses the has_changed()
 method for the same purpose so I can't figure out why it is done
 differently in the save_existing_objects method.

 I have attached a patch to fix this.

 Thank you!

-- 
Ticket URL: <http://code.djangoproject.com/ticket/10038>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to