#10235: contrib.sitemaps doesn't support RequestSite
-----------------------------------+----------------------------------------
Reporter: arthurk | Owner: nobody
Status: new | Milestone: post-1.0
Component: Contrib apps | Version: 1.0
Resolution: | Keywords: sitemap
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
-----------------------------------+----------------------------------------
Changes (by adrian):
* needs_better_patch: => 0
* stage: Unreviewed => Accepted
* needs_tests: => 0
* needs_docs: => 0
Comment:
I agree that contrib.sitemaps should support {{{RequestSite}}} -- but
before we do that, maybe we should make a helper function that does the
following logic (which is repeated multiple times in this patch):
{{{
from django.contrib.sites.models import Site, RequestSite
if Site._meta.installed:
current_site = Site.objects.get_current()
else:
current_site = RequestSite(request)
}}}
--
Ticket URL: <http://code.djangoproject.com/ticket/10235#comment:1>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
