#9204: Google Maps Marker to change the Icon
---------------------------------+------------------------------------------
Reporter: qingfeng | Owner: jbronn
Status: new | Milestone: post-1.0
Component: GIS | Version: 1.0
Resolution: | Keywords: geodjango google map icon
gicon
Stage: Unreviewed | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
---------------------------------+------------------------------------------
Comment (by prairiedogg):
I just submitted "more_complete_gicon_patch.diff", this implements the
previously alluded name argument (although unique names are not enforced).
I also did a very small refactor of the overlay argument -> instance
variables in overlays.py.
Also, when I ran part of my patch by someone on #python they made 2
suggestions, which I'll just throw out here.
The first was that def statements should not assign empty mutable types,
see:
http://effbot.org/pyfaq/why-are-default-values-shared-between-objects.htm
So I changed my code to incorporate that suggestion, I notice that there
are some other places that could be updated, but I'll leave it to others
who are more knowledgeable to make that determination.
The second suggestion was that the isinstance() method of type checking
was not very pythonic. I don't know if that bothers you or not Justin,
just thought I'd throw it out there.
Would love to hear any comments.
--
Ticket URL: <http://code.djangoproject.com/ticket/9204#comment:8>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
