#2131: [patch] HttpResponseSendFile for serving static files handler-specific sendfile mechanism -----------------------------------------------+---------------------------- Reporter: ymasuda[at]ethercube.com | Owner: alsleme Status: new | Milestone: post-1.0 Component: Core framework | Version: SVN Resolution: | Keywords: Stage: Design decision needed | Has_patch: 1 Needs_docs: 0 | Needs_tests: 1 Needs_better_patch: 0 | -----------------------------------------------+---------------------------- Comment (by jacob):
This looks like a nice patch to me, and hearing that it works in production is good to know. Still needs a few things, though: * The current setup requires cooperation between the `HttpResponseSendFile` object and the handler. This means it'll break if `HttpResponseSendFile` is used with a custom handler that doesn't know about it; that's a potential backwards-incompatibility, and we need to avoid it. If possible, `HttpResponseSendFile` needs to fake being a regular `HttpResponse`, probably by providing a `content` property which just reads the file. * Documentation. * Tests. -- Ticket URL: <http://code.djangoproject.com/ticket/2131#comment:21> Django <http://code.djangoproject.com/> The Web framework for perfectionists with deadlines. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to django-updates@googlegroups.com To unsubscribe from this group, send email to django-updates+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-updates?hl=en -~----------~----~----~----~------~----~------~--~---