Author: mtredinnick
Date: 2009-02-28 19:24:03 -0600 (Sat, 28 Feb 2009)
New Revision: 9924
Modified:
django/trunk/django/db/models/sql/query.py
django/trunk/tests/regressiontests/queries/models.py
Log:
Fixed #10202 -- Fixed another couple of slicing edge-cases with querysets.
Patch from Alex Gaynor and Ramiro Morales.
Modified: django/trunk/django/db/models/sql/query.py
===================================================================
--- django/trunk/django/db/models/sql/query.py 2009-02-28 06:05:44 UTC (rev
9923)
+++ django/trunk/django/db/models/sql/query.py 2009-03-01 01:24:03 UTC (rev
9924)
@@ -345,7 +345,7 @@
# in SQL (in variants that provide them) doesn't change the COUNT
# output.
number = max(0, number - self.low_mark)
- if self.high_mark:
+ if self.high_mark is not None:
number = min(number, self.high_mark - self.low_mark)
return number
@@ -1760,7 +1760,7 @@
Typically, this means no limits or offsets have been put on the
results.
"""
- return not (self.low_mark or self.high_mark)
+ return not self.low_mark and self.high_mark is None
def clear_select_fields(self):
"""
Modified: django/trunk/tests/regressiontests/queries/models.py
===================================================================
--- django/trunk/tests/regressiontests/queries/models.py 2009-02-28
06:05:44 UTC (rev 9923)
+++ django/trunk/tests/regressiontests/queries/models.py 2009-03-01
01:24:03 UTC (rev 9924)
@@ -903,11 +903,17 @@
>>> Item.objects.filter(created__in=[time1, time2])
[<Item: one>, <Item: two>]
-Bug #7698 -- People like to slice with '0' as the high-water mark.
+Bug #7698, #10202 -- People like to slice with '0' as the high-water mark.
>>> Item.objects.all()[0:0]
[]
>>> Item.objects.all()[0:0][:10]
[]
+>>> Item.objects.all()[:0].count()
+0
+>>> Item.objects.all()[:0].latest('created')
+Traceback (most recent call last):
+ ...
+AssertionError: Cannot change a query once a slice has been taken.
Bug #7411 - saving to db must work even with partially read result set in
another cursor.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
