#9964: Transaction middleware closes the transaction only when it's marked as
dirty
---------------------------------------------------+------------------------
Reporter: ishirav | Owner:
mtredinnick
Status: assigned | Milestone: 1.1
Component: Database layer (models, ORM) | Version: 1.0-beta-1
Resolution: | Keywords:
transactions
Stage: Accepted | Has_patch: 1
Needs_docs: 1 | Needs_tests: 0
Needs_better_patch: 0 |
---------------------------------------------------+------------------------
Changes (by shai):
* needs_better_patch: 1 => 0
* needs_tests: 1 => 0
Comment:
The new patch includes tests, which it passed.
Malcolm has expressed, in the mailing list, preference for a trivial
patch; however, the trivial patches considered took it upon Django to
select for the users, whether they should take a performance hit (compared
to 1.0), or check their code better. The attached patch leaves this choice
to the users (as detailed above).
I removed the "need tests" and "need better patch" flags, because it is my
opinion now that the tests and patch are good, and viable for looking
into. I do not presume to take the role of a committer; I hope this is the
right way to do it.
I have to add a word on testing here, but I must run to get some kids from
school now.
--
Ticket URL: <http://code.djangoproject.com/ticket/9964#comment:10>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
