#8630: Improve the comments framework customizability
----------------------------------------------+-----------------------------
Reporter: thejaswi_puthraya | Owner: carljm
Status: closed | Milestone:
Component: django.contrib.comments | Version: SVN
Resolution: fixed | Keywords: comments,
customization
Stage: Accepted | Has_patch: 1
Needs_docs: 0 | Needs_tests: 0
Needs_better_patch: 0 |
----------------------------------------------+-----------------------------
Comment (by thejaswi_puthraya):
Hi Josh,
Thanks for your comments. They have been invaluable and they have helped
us locate a bug elsewhere.
Replying to [comment:23 joshvanwyck]:
> Greetings,
>
> I'm trying to take advantage of the newest version of the django's
customizable comments framework. I am following all the documentation
when I try and implement a simple comment system that has an additional
field. I tried initially with a BooleanField, but have since resorted to
trying to simply follow the example from the documentation provided.
>
> When I run it, I get the following error message:
> Caught an exception while rendering: Cannot resolve keyword 'is_public'
into field. Choices are: content_type, id, object_pk, site, title
>
> I suspect that this is a bug or either mistaken documentation, as I'm
assuming if I follow the example online character for character it should
work.
>
Ideally you should be subclassing from the Comment Model. But if your
requirements are different, then BaseCommentAbstractModel should do. This
problem was fixed in [9891] but there is a small typo in that.
Will reopen that ticket and get it fixed. Also I will open a ticket for
patching the documentation that makes it very clear.
> A couple of things I've found by digging through the code. If we extend
the BaseCommentAbstractModel, how can we receive the Comment model's
fields? Why does line 84 of templatetags/comments.py contain is_public =
true. This field will only exist if we have extended the Comment model but
this isn't an option as we are supposed to extend the
BaseCommentAbstractModel.
>
> Also the unit testing doesn't seem to test the rendering which is where
the problems seem to be occurring.
>
> Maybe I'm completely off here, this is my first time posting any
comments so if I have broken any posting rules please let me know.
>
> Thanks for your work on this portion.
>
> Josh
--
Ticket URL: <http://code.djangoproject.com/ticket/8630#comment:25>
Django <http://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to
[email protected]
For more options, visit this group at
http://groups.google.com/group/django-updates?hl=en
-~----------~----~----~----~------~----~------~--~---
